Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force new splits into their own new window when Option key is held down. #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnSpeno
Copy link
Contributor

I wanted to resubmit this patch that adds a new feature to the Sessions window. If a user holds down the Option key while pressing either of the Split buttons, then the selected sessions will open in a new window split in the requested way. I use this nearly each time I use iTerm. If there are required changes, let's discuss them here and alter the pull request as needed. Thanks.

@gnachman
Copy link
Owner

I feel like this could work if there were some visual indication when you press option, like the button labels changing. There's not a lot of space to work with, though, so it'll be tricky to find the right UI. I'm not married to the existing one, which is pretty weird, so don't be afraid to make radical changes.

@JohnSpeno
Copy link
Contributor Author

I still have no UI chops. My lame idea was to put a string bellow the buttons that read "Holding down option key will open splits in a new window." How do you feel about that?

@gnachman
Copy link
Owner

gnachman commented Apr 8, 2013

Hm, I think it needs more work. I wonder if this is something that should be scripted since it's kind of an edge case. But I'm not really sure how scripting would hook into it either, since it needs some UI. I'm kinda stuck on this one at the moment.

@JohnSpeno
Copy link
Contributor Author

The Mac has a long history of hidden features activated by holding down the Option key. For example, clicking on the Speak or Wi-Fi icons in the menu bar reveal different content when the Option key is down. My patch continues that proud tradition. :-)

@gnachman
Copy link
Owner

Here's what I think: we can add an icon to the buttons (shown only when option is pressed) to indicate that a new window will be used. For example, this: http://png.findicons.com/files/icons/2315/default_icon/128/open_in_new_window.png
We can eliminate the clunky "new tabs in new window", moving that functionality into opt+"new tab". Add a label that says "Press option to open in profiles in a new window", shown only when multiple profiles are selected.

@JohnSpeno
Copy link
Contributor Author

I like how you think. When multiple profiles are selected, it would be best to have the 'New Window' button change its text to 'New Windows'.

@gnachman
Copy link
Owner

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants