fix(ffmpeg): fix issue for start and durtion argument position

gnes-ai · Aug 27, 2019 · 0215c6b · 0215c6b
1 parent 1ea487f
commit 0215c6b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/gnes/preprocessor/io_utils/ffmpeg.py b/gnes/preprocessor/io_utils/ffmpeg.py
@@ -92,8 +92,15 @@ def compile_args(input_fn: str = 'pipe:',
     if fmt:
         input_args += ['-f', fmt]
 
+    start_time = input_options.pop('ss', None)
+    duration = input_options.pop('t', None)
+
     input_args += kwargs_to_cmd_args(input_options)
     input_args += ['-i', input_fn]
+    if start_time is not None:
+        input_args += ['-ss', str(start_time)]
+    if duration is not None:
+        input_args += ['-t', str(duration)]
 
     vf_args = []
     if len(video_filters) > 0:

diff --git a/tests/test_ffmpeg_tools.py b/tests/test_ffmpeg_tools.py
@@ -65,7 +65,9 @@ def test_capture_audio(self):
             self.assertEqual(audio_data1.shape, audio_data2.shape)
 
     def test_split_audio(self):
-        audio.split_audio(input_fn=self.video_path)
+        chunks1 = audio.split_audio(input_fn=self.video_path)
         with open(self.video_path, 'rb') as f:
             data = f.read()
-            audio.split_audio(input_data=data)
+            chunks2 = audio.split_audio(input_data=data)
+            self.assertEqual(len(chunks1), len(chunks2))
+            self.assertEqual(chunks1[0].shape, chunks2[0].shape)