Merge branch 'master' into feat-standardscaler

CONTRIBUTING.md

@@ -8,8 +8,8 @@ The beginning is always the hardest. But fear not, even if you find a typo, a mi
 
 1. Create a new branch, say `fix-gnes-typo-1`
 2. Fix/improve the codebase
-3. Commit the changes. Note the **commit message must follow [the naming style]((#commit-message-naming))**, say `fix(readme): improve the readability and move sections`
-4. Make a pull request. Note the **commit message must follow [the naming style]((#commit-message-naming))**. It can simply be one of your commit messages, just copy paste it, e.g. `fix(readme): improve the readability and move sections`
+3. Commit the changes. Note the **commit message must follow [the naming style](#commit-message-naming)**, say `fix(readme): improve the readability and move sections`
+4. Make a pull request. Note the **commit message must follow [the naming style](#commit-message-naming)**. It can simply be one of your commit messages, just copy paste it, e.g. `fix(readme): improve the readability and move sections`
 5. Submit your pull request and wait for all checks passed (usually 10 minutes)
     - Coding style
     - Commit and PR styles check

README.md

@@ -465,8 +465,8 @@ We have setup [this repository](https://github.com/gnes-ai/benchmark) to track t
 
 1. Create a new branch, say `fix-gnes-typo-1`
 2. Fix/improve the codebase
-3. Commit the changes. Note the **commit message must follow [the naming style]((#commit-message-naming))**, say `fix(readme): improve the readability and move sections`
-4. Make a pull request. Note the **pull request must follow [the naming style]((#commit-message-naming))**. It can simply be one of your commit messages, just copy paste it, e.g. `fix(readme): improve the readability and move sections`
+3. Commit the changes. Note the **commit message must follow [the naming style](./CONTRIBUTING.md#commit-message-naming)**, say `fix(readme): improve the readability and move sections`
+4. Make a pull request. Note the **pull request must follow [the naming style](./CONTRIBUTING.md#commit-message-naming)**. It can simply be one of your commit messages, just copy paste it, e.g. `fix(readme): improve the readability and move sections`
 5. Submit your pull request and wait for all checks passed (usually 10 minutes)
     - Coding style
     - Commit and PR styles check

gnes/flow/__init__.py

@@ -416,7 +416,7 @@ def _get_client(self, bytes_gen: Iterator[bytes] = None, **kwargs):
         from ..cli.parser import set_client_cli_parser
         from ..client.cli import CLIClient
 
-        args, p_args, unk_args = self._get_parsed_args(self, set_client_cli_parser, kwargs)
+        _, p_args, _ = self._get_parsed_args(self, CLIClient.__name__, set_client_cli_parser, kwargs)
         p_args.grpc_port = self._service_nodes[self._frontend]['parsed_args'].grpc_port
         p_args.grpc_host = self._service_nodes[self._frontend]['parsed_args'].grpc_host
         c = CLIClient(p_args, start_at_init=False)
@@ -534,7 +534,7 @@ def set(self, name: str, recv_from: Union[str, Tuple[str], List[str], 'Service']
             if not clear_old_attr:
                 node['kwargs'].update(kwargs)
                 kwargs = node['kwargs']
-            args, p_args, unk_args = op_flow._get_parsed_args(op_flow, service_map[service]['parser'], kwargs)
+            args, p_args, unk_args = op_flow._get_parsed_args(op_flow, name, service_map[service]['parser'], kwargs)
             node.update({
                 'args': args,
                 'parsed_args': p_args,
@@ -635,7 +635,7 @@ def add(self, service: Union['Service', str],
         recv_from = op_flow._parse_service_endpoints(op_flow, name, recv_from, connect_to_last_service=True)
         send_to = op_flow._parse_service_endpoints(op_flow, name, send_to, connect_to_last_service=False)
 
-        args, p_args, unk_args = op_flow._get_parsed_args(op_flow, service_map[service]['parser'], kwargs)
+        args, p_args, unk_args = op_flow._get_parsed_args(op_flow, name, service_map[service]['parser'], kwargs)
 
         op_flow._service_nodes[name] = {
             'service': service,
@@ -686,7 +686,7 @@ def _parse_service_endpoints(op_flow, cur_service_name, service_endpoint, connec
         return set(service_endpoint)
 
     @staticmethod
-    def _get_parsed_args(op_flow, service_arg_parser, kwargs):
+    def _get_parsed_args(op_flow, name, service_arg_parser, kwargs):
         kwargs.update(op_flow._common_kwargs)
         args = []
         for k, v in kwargs.items():
@@ -709,7 +709,7 @@ def _get_parsed_args(op_flow, service_arg_parser, kwargs):
                 op_flow.logger.warning('not sure what these arguments are: %s' % unknown_args)
         except SystemExit:
             raise ValueError('bad arguments for service "%s", '
-                             'you may want to double check your args "%s"' % (service_arg_parser, args))
+                             'you may want to double check your args "%s"' % (name, args))
         return args, p_args, unknown_args
 
     def _build_graph(self, copy_flow: bool) -> 'Flow':