fix(subprocess): close stdout and stderr to avoid memory leak

gnes-ai · Sep 20, 2019 · 780aad0 · 780aad0
1 parent 205962f
commit 780aad0
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/gnes/preprocessor/io_utils/helper.py b/gnes/preprocessor/io_utils/helper.py
@@ -45,7 +45,8 @@ def run_command_async(cmd_args,
         cmd_args,
         stdin=stdin_stream,
         stdout=stdout_stream,
-        stderr=stderr_stream)
+        stderr=stderr_stream,
+        close_fds=True)
 
 
 def wait(process):
@@ -76,4 +77,10 @@ def run_command(cmd_args,
 
         if retcode:
             raise Exception('ffmpeg error: %s' % stderr)
+
+        if proc.stdout is not None:
+            proc.stdout.close()
+        if proc.stderr is not None:
+            proc.stderr.close()
+
         return stdout, stderr