Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

feat(preprocessor): add frame selector #290

Merged
merged 4 commits into from
Sep 25, 2019
Merged

feat(preprocessor): add frame selector #290

merged 4 commits into from
Sep 25, 2019

Conversation

jemmyshin
Copy link
Contributor

No description provided.

@jemmyshin jemmyshin requested a review from numb3r3 September 25, 2019 05:20
self.logger.info("this chunk has no frame!")
if self.sframes == -1:
self.logger.info("keep all frames!")
elif self.sframes > len(images):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@line 40, elif self.sframes > len(images) ?

chunk.blob.CopyFrom(array2blob(images[idx]))
else:
idx = []
rs = ReservoirSample(self.sframes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer the sampler implemented in shot-detector preprocessor

Copy link
Contributor

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update sampler implementation in shot-detector, 3x

for chunk in doc.chunks:
images = blob2array(chunk.blob)
if len(images) == 0:
self.logger.info("this chunk has no frame!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use self.logger.warning

@mergify mergify bot merged commit 1ce6350 into master Sep 25, 2019
@mergify mergify bot deleted the frame_selector_ branch September 25, 2019 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants