This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
feat(service): add healthcheck for arbitrary service #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 26, 2019 12:32
added 2 commits
September 26, 2019 15:30
numb3r3
reviewed
Sep 26, 2019
| 'you may ignore it in debug/unittest mode, ' | ||
| 'or if you run gnes OUTSIDE docker container where GNES_VCS_VERSION is unset' | ||
| 'otherwise please check if frontend service set correct version') | ||
| elif os.environ.get('GNES_VCS_VERSION') != msg.envelope.vcs_version: |
There was a problem hiding this comment.
In this case, the env GNES_VCS_VERSION must be available?
numb3r3
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.