feat(cmd/gno): lint all files in folder before panicking (#2202)

This Pull request intents to follow up on #2011. As said on that Pull
request, currently we show all lint errors on the first analyzed file.
If in a folder we have `a.gno` & `b.gno` both with lint errors. `gno
lint | run | test` will only find the errors related to one of those
files.

**This PR aims to show all the lint errors present on the current
folder**.

Changes:
for lint &  test cmd:
- we modified ParseMemPackage function on gnovm/pkg/gnoland/nodes.go.
Before this function returned as soon as an error was found while
Parsing the gno file. So we introduced an error slice to keep track of
all Parse errors. After parsing all the files we panic with the list of
errors only if this list is not empty.
- we did the same on parseMemPackageTests function 
- create a function printRuntimeError that handles the print of the
errors inside `catchRuntimeError` function. We did this change in order
to be able to recursively call the funtion and handle the case of an
[]error type composed of scanner.ErrorList errors.

### Results
* running on gnovm/tests/integ/several-files-multiple/errors
LINT (before):
```sh
several-files-multiple-errors % gno lint .
file2.gno:3: expected 'IDENT', found '{' (code=2).
file2.gno:5: expected type, found '}' (code=2).
```

LINT (after):
```sh
gno lint .
file2.gno:3: expected 'IDENT', found '{' (code=2).
file2.gno:5: expected type, found '}' (code=2).
main.gno:5: expected ';', found example (code=2).
main.gno:6: expected '}', found 'EOF' (code=2).
exit status 1
```

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details>

<summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

gnovm/cmd/gno/lint.go

@@ -17,6 +17,7 @@ import (
 	"github.com/gnolang/gno/gnovm/tests"
 	"github.com/gnolang/gno/tm2/pkg/commands"
 	osm "github.com/gnolang/gno/tm2/pkg/os"
+	"go.uber.org/multierr"
 )
 
 type lintCfg struct {
@@ -174,12 +175,18 @@ func catchRuntimeError(pkgPath string, stderr io.WriteCloser, action func()) (ha
 		case *gno.PreprocessError:
 			err := verr.Unwrap()
 			fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
-		case scanner.ErrorList:
-			for _, err := range verr {
-				fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
-			}
 		case error:
-			fmt.Fprint(stderr, issueFromError(pkgPath, verr).String()+"\n")
+			errors := multierr.Errors(verr)
+			for _, err := range errors {
+				errList, ok := err.(scanner.ErrorList)
+				if ok {
+					for _, errorInList := range errList {
+						fmt.Fprint(stderr, issueFromError(pkgPath, errorInList).String()+"\n")
+					}
+				} else {
+					fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
+				}
+			}
 		case string:
 			fmt.Fprint(stderr, issueFromError(pkgPath, errors.New(verr)).String()+"\n")
 		default:

gnovm/cmd/gno/lint_test.go

@@ -23,6 +23,10 @@ func TestLintApp(t *testing.T) {
 			args:                []string{"lint", "../../tests/integ/several-lint-errors/main.gno"},
 			stderrShouldContain: "../../tests/integ/several-lint-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-lint-errors/main.gno:6",
 			errShouldBe:         "exit code: 1",
+		}, {
+			args:                []string{"lint", "../../tests/integ/several-files-multiple-errors/main.gno"},
+			stderrShouldContain: "../../tests/integ/several-files-multiple-errors/file2.gno:3: expected 'IDENT', found '{' (code=2).\n../../tests/integ/several-files-multiple-errors/file2.gno:5: expected type, found '}' (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:6: expected '}', found 'EOF' (code=2).\n",
+			errShouldBe:         "exit code: 1",
 		}, {
 			args:                []string{"lint", "../../tests/integ/run_main/"},
 			stderrShouldContain: "./../../tests/integ/run_main: missing 'gno.mod' file (code=1).",

gnovm/cmd/gno/run_test.go

@@ -83,6 +83,11 @@ func TestRunApp(t *testing.T) {
 			args:                []string{"run", "-expr", "Context()", "../../tests/integ/context/context.gno"},
 			stdoutShouldContain: "Context worked",
 		},
+		{
+			args:                []string{"run", "../../tests/integ/several-files-multiple-errors/"},
+			stderrShouldContain: "../../tests/integ/several-files-multiple-errors/file2.gno:3: expected 'IDENT', found '{' (code=2).\n../../tests/integ/several-files-multiple-errors/file2.gno:5: expected type, found '}' (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:6: expected '}', found 'EOF' (code=2).",
+			errShouldBe:         "exit code: 1",
+		},
 		// TODO: a test file
 		// TODO: args
 		// TODO: nativeLibs VS stdlibs

gnovm/cmd/gno/test.go

@@ -577,6 +577,7 @@ func loadTestFuncs(pkgName string, t *testFuncs, tfiles *gno.FileSet) *testFuncs
 func parseMemPackageTests(memPkg *std.MemPackage) (tset, itset *gno.FileSet) {
 	tset = &gno.FileSet{}
 	itset = &gno.FileSet{}
+	var errs error
 	for _, mfile := range memPkg.Files {
 		if !strings.HasSuffix(mfile.Name, ".gno") {
 			continue // skip this file.
@@ -586,7 +587,8 @@ func parseMemPackageTests(memPkg *std.MemPackage) (tset, itset *gno.FileSet) {
 		}
 		n, err := gno.ParseFile(mfile.Name, mfile.Body)
 		if err != nil {
-			panic(err)
+			errs = multierr.Append(errs, err)
+			continue
 		}
 		if n == nil {
 			panic("should not happen")
@@ -606,6 +608,9 @@ func parseMemPackageTests(memPkg *std.MemPackage) (tset, itset *gno.FileSet) {
 				memPkg.Name, memPkg.Name, n.PkgName, mfile))
 		}
 	}
+	if errs != nil {
+		panic(errs)
+	}
 	return tset, itset
 }
 

gnovm/pkg/gnolang/nodes.go

@@ -14,6 +14,7 @@ import (
 
 	"github.com/gnolang/gno/tm2/pkg/errors"
 	"github.com/gnolang/gno/tm2/pkg/std"
+	"go.uber.org/multierr"
 )
 
 // ----------------------------------------
@@ -1189,14 +1190,16 @@ func ReadMemPackageFromList(list []string, pkgPath string) *std.MemPackage {
 // or [ParseFile] returns an error, ParseMemPackage panics.
 func ParseMemPackage(memPkg *std.MemPackage) (fset *FileSet) {
 	fset = &FileSet{}
+	var errs error
 	for _, mfile := range memPkg.Files {
 		if !strings.HasSuffix(mfile.Name, ".gno") ||
 			endsWith(mfile.Name, []string{"_test.gno", "_filetest.gno"}) {
 			continue // skip spurious or test file.
 		}
 		n, err := ParseFile(mfile.Name, mfile.Body)
 		if err != nil {
-			panic(err)
+			errs = multierr.Append(errs, err)
+			continue
 		}
 		if memPkg.Name != string(n.PkgName) {
 			panic(fmt.Sprintf(
@@ -1206,6 +1209,9 @@ func ParseMemPackage(memPkg *std.MemPackage) (fset *FileSet) {
 		// add package file.
 		fset.AddFiles(n)
 	}
+	if errs != nil {
+		panic(errs)
+	}
 	return fset
 }
 

gnovm/tests/integ/several-files-multiple-errors/file2.gno

@@ -0,0 +1,5 @@
+package main
+
+type{
+
+}

gnovm/tests/integ/several-files-multiple-errors/gno.mod

@@ -0,0 +1 @@
+module gno.land/tests/severalerrors

gnovm/tests/integ/several-files-multiple-errors/main.gno

@@ -0,0 +1,6 @@
+package main
+
+func main() {
+	for {
+		_ example
+}