Skip to content

Commit

Permalink
feat: clean up gnokey add + add coverage (#1212)
Browse files Browse the repository at this point in the history
## Description

This PR initially started out as adding support for account derivation
to `gnokey add`. However, over the discussions, it turned into a bigger
cleanup of the `gnokey add` subcommand suite.

Changes done:
- extracted ledger support into `gnokey add ledger`
- extracted multisig support into `gnokey add multisig`
- extracted bech32 public key support into `gnokey add bech32`
- added coverage (unit tests) for all functionality, even though they
were previously missing
- added the `--derive-path` flag to the base `gnokey add` (original
functionality of the PR)

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
  • Loading branch information
zivkovicmilos authored Apr 26, 2024
1 parent 8cc5636 commit fdde3d0
Show file tree
Hide file tree
Showing 17 changed files with 1,439 additions and 311 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tm2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
working-directory: tm2
run: |
export GOPATH=$HOME/go
export GOTEST_FLAGS="-v -p 1 -timeout=20m -coverprofile=coverage.out -covermode=atomic"
export GOTEST_FLAGS="-v -p 1 -timeout=20m -coverprofile=coverage.out -covermode=atomic -tags='ledger_suite'"
make ${{ matrix.args }}
touch coverage.out
- uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion tm2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GOFMT_FLAGS ?= -w
# flags for `make imports`.
GOIMPORTS_FLAGS ?= $(GOFMT_FLAGS)
# test suite flags.
GOTEST_FLAGS ?= -v -p 1 -timeout=30m
GOTEST_FLAGS ?= -v -p 1 -timeout=30m -tags='ledger_suite'

########################################
# Dev tools
Expand Down
Loading

0 comments on commit fdde3d0

Please sign in to comment.