-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reminder: need to set VerifyGenesisSignatures to true on mainnet, #1104
Comments
This is a simple fix, but we actually want to revert it to continue development. I suggest making this either a configuration file option that can be changed without patching the codebase or a fuse variable that can be set with a transaction. This way, we can expect a chain to start as |
Thinking about this issue a bit, I don't think having You need a few things to generate a transaction signature in the Lines 112 to 117 in 2093d8a
Notice that you can specify all params, apart from the I suggest 2 options:
|
closes #1104 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
We need to verifying the signatures of txs in genesis file upon mainnet launch. We might want to set default to true before the release. This could be a backdoor for production
gno/gno.land/pkg/gnoland/app.go
Line 54 in 4bd1789
The text was updated successfully, but these errors were encountered: