Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gnoclient] Add support for MsgAddPackage #1840

Closed
leohhhn opened this issue Mar 26, 2024 · 0 comments · Fixed by #1892
Closed

[gnoclient] Add support for MsgAddPackage #1840

leohhhn opened this issue Mar 26, 2024 · 0 comments · Fixed by #1892
Assignees
@leohhhn

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Mar 26, 2024 •
edited
Loading

Description

As title says, gnoclient currently does not support MsgAddPackage.

Handled in #1892
@leohhhn leohhhn changed the title Gnoclient: Add support for MsgAddPackage [gnoclient] Add support for MsgAddPackage Mar 27, 2024
@zivkovicmilos zivkovicmilos moved this from Backlog to Priority 1 in 👥 Team: Devrels (Outdated) Mar 30, 2024
@leohhhn leohhhn moved this from Priority 1 to In Progress in 👥 Team: Devrels (Outdated) Apr 5, 2024
@leohhhn leohhhn mentioned this issue Apr 5, 2024
Merged
7 tasks
@leohhhn leohhhn moved this from In Progress to In Review in 👥 Team: Devrels (Outdated) Apr 5, 2024
leohhhn added a commit that referenced this issue Apr 9, 2024
@leohhhn
feat(gnoclient): add support for MsgAddPackage (#1892)
60c09b9 
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

This PR adds gnoclient support for `MsgAddPackage`, and updates the docs
to match the functionality. Docs preview:
https://www.loom.com/share/0dfa38e6e95e4e1195d686c8cbffa453?sid=4af29ee0-d065-442c-977e-ce9577796688

Closes #1840 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@github-project-automation github-project-automation bot moved this from In Review to Done in 👥 Team: Devrels (Outdated) Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leohhhn leohhhn

Labels
None yet
Projects
👥 Team: Devrels (Outdated)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gnoclient): add support for MsgAddPackage leohhhn/gno
1 participant
@leohhhn