Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: gnokey list on help page links to a bad url #2925

Closed
MalekLahbib opened this issue Oct 8, 2024 · 2 comments · Fixed by #2926
Closed

bug: gnokey list on help page links to a bad url #2925

MalekLahbib opened this issue Oct 8, 2024 · 2 comments · Fixed by #2926
Assignees
@leohhhn

Comments

@MalekLahbib
Copy link
Contributor

Description

when doing a test, I clicked on see `gnokey list` on help page on https://test4.gno.land/r/demo/users?help

Screenshot 2024-10-08 at 11 42 54

and the link sent me to this url that seems to be no more good.

Screenshot 2024-10-08 at 11 43 32

the working url is this
@leohhhn leohhhn self-assigned this Oct 8, 2024
@leohhhn leohhhn mentioned this issue Oct 8, 2024
Merged
7 tasks
@leohhhn
Copy link
Contributor

leohhhn commented Oct 8, 2024

Thanks for noticing. I fixed it in #2926, but you're always welcome to fix these kinds of issues youself. It can also be a good way to learn about other parts of the codebase.

@leohhhn leohhhn closed this as completed Oct 8, 2024
@MalekLahbib
Copy link
Contributor Author

Thanks for noticing. I fixed it in #2926, but you're always welcome to fix these kinds of issues youself. It can also be a good way to learn about other parts of the codebase.

I would've done it if I knew where to do it. I searched for it, but maybe not the good way :). I will ask the next time.

leohhhn added a commit that referenced this issue Oct 8, 2024
@leohhhn
fix(gnoweb): fix broken link (#2926)
e5840e2 
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

Fixes a broken link. Closes: #2925 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@MalekLahbib MalekLahbib mentioned this issue Oct 15, 2024
Open
@leohhhn leohhhn mentioned this issue Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leohhhn leohhhn

Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gnoweb): fix broken link leohhhn/gno
2 participants
@leohhhn @MalekLahbib