Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid importing realms from pure packages (r/ from p/) #3040

Closed
Tracked by #2192
thehowl opened this issue Oct 28, 2024 · 0 comments · Fixed by #3042
Closed
Tracked by #2192

forbid importing realms from pure packages (r/ from p/) #3040

thehowl opened this issue Oct 28, 2024 · 0 comments · Fixed by #3042
Assignees
@MikaelVallenet
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors 📦 ⛰️ gno.land Issues or PRs gno.land package related
Milestone
🚀 Mainnet beta la...

Comments

@thehowl
Copy link
Member

thehowl commented Oct 28, 2024

This was originally started here: #1393

The work should be continued as a requirement for mainnet launch. Related: #2192. (Note, this is indeed still possible: https://gno.land/p/morgan/testimports/).

Seems like it was in Hariom's status updates for long enough that we just thought it got sorted out, while it wasn't, really.
@thehowl thehowl added 🗺️good first issue🗺️ Ideal for newcomer contributors 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 28, 2024
@thehowl thehowl added this to the 🚀 Mainnet launch milestone Oct 28, 2024
@thehowl thehowl mentioned this issue Oct 28, 2024
Open
5 tasks
@MikaelVallenet MikaelVallenet mentioned this issue Oct 28, 2024
Merged
6 tasks
@Kouteki Kouteki moved this from In Progress to Todo in 🧙‍♂️gno.land core team Nov 17, 2024
@Kouteki Kouteki moved this from Todo to In Progress in 🧙‍♂️gno.land core team Nov 17, 2024
@MikaelVallenet MikaelVallenet self-assigned this Nov 18, 2024
@Kouteki Kouteki moved this from Teritori (unconfirmed) to Teritori (confirmed) in 🍜 Seoul triage Nov 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team Nov 26, 2024
@Kouteki Kouteki mentioned this issue Dec 9, 2024
Open
r3v4s pushed a commit to gnoswap-labs/gno that referenced this issue Dec 10, 2024
@MikaelVallenet @n0izn0iz
@thehowl @r3v4s
feat(gnovm): forbid importing realms in packages (gnolang#3042)
98514d2 
Closes gnolang#3040 
50% of the work comes from @harry-hov's PR gnolang#1393 (let's repay to Caesar
what belongs to Caesar) 🚀

Notable additions:
- handle different domains (e.g github.com/p/demo/...)
- skip non ``.gno`` files (LICENSE, README, ...) or empty files


<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>

---------

Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikaelVallenet MikaelVallenet

Labels
🗺️good first issue🗺️ Ideal for newcomer contributors 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🍜 Seoul triage
Status: Teritori (confirmed)
🧙‍♂️gno.land core team
Status: Done
Milestone
🚀 Mainnet beta launch
Development

Successfully merging a pull request may close this issue.

feat(gnovm): forbid importing realms in packages MikaelVallenet/gno
2 participants
@thehowl @MikaelVallenet