-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tm2): make HTTPClient support https #1158
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 47.31% 47.38% +0.06%
==========================================
Files 367 367
Lines 62118 62118
==========================================
+ Hits 29394 29434 +40
+ Misses 30325 30296 -29
+ Partials 2399 2388 -11
☔ View full report in Codecov by Sentry. |
putting back as draft; want to add a regression test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix 🙏
Co-authored-by: Manfred Touron <[email protected]>
Gnochess hotfix (already on the gnochess branch, so no need to prioritize this).
There's two users of
parseRemoteAddr
:makeHTTPDialer
andtoClientAddrAndParse
. The former creates a net.Dialer, and needs to convert the protocol totcp
when it's http/https, while the latter doesn't, and its value is subsequently used to make the HTTP request itself.This fixes a bug when doing any query/tx with gnokey when using https:
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description