Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up gnokey add + add coverage #1212

Merged
merged 22 commits into from
Apr 26, 2024
Merged

feat: clean up gnokey add + add coverage #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e867c0a
Add in base gnokey derive command
zivkovicmilos Oct 9, 2023
d9afdbb
Add gnokey derive full command test
zivkovicmilos Oct 9, 2023
a73bb49
Change title output
zivkovicmilos Oct 9, 2023
313773b
Add unit test that covers the command init
zivkovicmilos Oct 11, 2023
3d98bb5
Merge branch 'master' into feat/add-gnokey-derive
zivkovicmilos Oct 20, 2023
c818b19
Merge branch 'master' into feat/add-gnokey-derive
zivkovicmilos Dec 1, 2023
6b2a39e
Transfer the logic to a flag
zivkovicmilos Dec 1, 2023
2e39ea6
Remove txtar test
zivkovicmilos Dec 1, 2023
a5dedd6
Merge branch 'master' into feat/add-gnokey-derive
zivkovicmilos Dec 21, 2023
4669acf
Merge master
zivkovicmilos Mar 30, 2024
8fdc4e5
Start breaking up gnokey add
zivkovicmilos Mar 30, 2024
29ac1ce
Add a derivation path check
zivkovicmilos Mar 30, 2024
34d8bb4
Add unit tests for path derivation
zivkovicmilos Mar 30, 2024
aadd296
Add unit tests for bech32 addition
zivkovicmilos Apr 1, 2024
ac7d5e2
Add unit tests for multisig
zivkovicmilos Apr 1, 2024
a68843b
Add Ledger unit tests
zivkovicmilos Apr 2, 2024
ca415d2
Fix flaky test
zivkovicmilos Apr 2, 2024
fd07f58
Add tag in workflow
zivkovicmilos Apr 2, 2024
9a4c9f8
Wrap up skipped tests
zivkovicmilos Apr 16, 2024
88dac1b
Merge branch 'master' into feat/add-gnokey-derive
zivkovicmilos Apr 22, 2024
edb541e
Merge branch 'master' into feat/add-gnokey-derive
zivkovicmilos Apr 26, 2024
9efe4b0
Remove duplicate helper
zivkovicmilos Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tm2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
working-directory: tm2
run: |
export GOPATH=$HOME/go
export GOTEST_FLAGS="-v -p 1 -timeout=20m -coverprofile=coverage.out -covermode=atomic"
export GOTEST_FLAGS="-v -p 1 -timeout=20m -coverprofile=coverage.out -covermode=atomic -tags='ledger_suite'"
make ${{ matrix.args }}
touch coverage.out
- uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion tm2/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GOFMT_FLAGS ?= -w
# flags for `make imports`.
GOIMPORTS_FLAGS ?= $(GOFMT_FLAGS)
# test suite flags.
GOTEST_FLAGS ?= -v -p 1 -timeout=30m
GOTEST_FLAGS ?= -v -p 1 -timeout=30m -tags='ledger_suite'

########################################
# Dev tools
Expand Down
Loading
Loading