Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gno bug #1325

Merged
merged 21 commits into from
Feb 29, 2024
Merged

feat: implement gno bug #1325

merged 21 commits into from
Feb 29, 2024

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Oct 31, 2023

Contains initial implementation of gno bug command.

gno-bug

Closes #733

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@harry-hov harry-hov added the 🌱 feature New update to Gno label Oct 31, 2023
@harry-hov harry-hov self-assigned this Oct 31, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.47%. Comparing base (75539ea) to head (7da403a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   47.23%   47.47%   +0.23%     
==========================================
  Files         363      385      +22     
  Lines       59493    61376    +1883     
==========================================
+ Hits        28104    29139    +1035     
- Misses      29066    29802     +736     
- Partials     2323     2435     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harry-hov harry-hov marked this pull request as ready for review November 4, 2023 15:00
@harry-hov harry-hov requested a review from a team as a code owner November 4, 2023 15:00
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments that need to be addressed before we proceed.

Please take a look 🙏

gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/util.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug_test.go Show resolved Hide resolved
gnovm/cmd/gno/util.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
@harry-hov harry-hov marked this pull request as ready for review February 13, 2024 19:42
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/main.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/bug.go Outdated Show resolved Hide resolved
@harry-hov harry-hov requested a review from a team as a code owner February 23, 2024 21:03
@thehowl thehowl dismissed zivkovicmilos’s stale review February 29, 2024 16:59

Outdated; changes addressed.

@thehowl thehowl merged commit 9b37107 into gnolang:master Feb 29, 2024
189 of 191 checks passed
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Mar 6, 2024
Contains initial implementation of `gno bug` command.


![gno-bug](https://github.com/gnolang/gno/assets/37576387/c1357f99-dcfd-4d80-8b54-cd1a0caba12b)

Closes gnolang#733 

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Manfred Touron <[email protected]>
Co-authored-by: Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🌱 feature New update to Gno
Projects
Status: Done
Status: 🔵 Not Needed for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

Add gno bug subcommand
4 participants