-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message output in integration tests #1349
Conversation
Signed-off-by: gfanton <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
- Coverage 55.94% 55.59% -0.35%
==========================================
Files 420 420
Lines 65415 65413 -2
==========================================
- Hits 36596 36369 -227
- Misses 25961 26197 +236
+ Partials 2858 2847 -11 ☔ View full report in Codecov by Sentry. |
I prefer the new output 👍 Can you check how much we could improve the package/errors instead of avoiding using it? |
@moul sure ! Let me check |
…ead of wrap" This reverts commit ce31780. Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
I've reverted my changes and will simply use "%+v" instead of "%v" for the integration tests. It took me a while to notice that we are using a custom format for our errors. For now, this change is sufficient as my main goal was to improve the error output of the gnokey command within the integration tests. That said, I believe there is room for improvement in error handling, as we should not need to use this kind of format to obtain the source error. Do you think we can update our errors package to use a more recent format, wrapping |
gnokey
error message
This PR improves error output in integration tests by using more verbose format.
gnokey
will now display the full stack trace log, including the underlying error, when an error occurs, instead of only presenting the top-level error.This enhancement will assist in better debugging what's happening without the need to delve directly into gnoland logs.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description