fix(r/demo/boards): correctly render reposts #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
- Coverage 56.10% 55.86% -0.25%
==========================================
Files 432 431 -1
Lines 66076 65834 -242
==========================================
- Hits 37075 36775 -300
- Misses 26104 26178 +74
+ Partials 2897 2881 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jeff Thompson <[email protected]>
…reposts Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
chore/boards-show-reposts
branch
from
c1d72b3 to
5c82d64
Compare
leohhhn
approved these changes
Jan 29, 2024
thehowl
reviewed
Jan 31, 2024
thehowl
approved these changes
Jan 31, 2024
thehowl
changed the title
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 2, 2024
r/demo/boards already implements the data structures for reposts and the API function [CreateRepost](https://github.com/gnolang/gno/blob/a1c9a8c142038a9624a035262b899a24e16ff3cd/examples/gno.land/r/demo/boards/public.gno#L87). But the Render display doesn't handle reposts correctly. I did a repost on test3 with: ``` gnokey maketx call -pkgpath "gno.land/r/demo/boards" -func "CreateRepost" -gas-fee 1000000ugnot -gas-wanted 5000000 -send "" -broadcast -chainid "test3" -args "1" -args "2" -args "" -args "check out this NFT post" -args "3" -remote "test3.gno.land:36657" jefft0 ``` This should display on board number 3 "boardtest". https://test3.gno.land/r/demo/boards:boardtest . Indeed, it shows ``` check out this NFT post - @jefft0, 2024-01-12 4:24pm UTC [x] (0 replies) ``` But when I click on the date to see the post, [the page](https://test3.gno.land/r/demo/boards:boardtest/2/2) shows "reply does not exist with id: 2" because Render incorrectly treats a repost as a reply. This pull request is one approach to displaying reposts. It has three commits. The first commit adds `GetRepostFormURL` (similar to `GetReplyFormURL`) and updates `RenderPost` with a helper for [repost] (similar to [reply]). It also updates `RenderSummary` to check if the post is a repost and displays the reposted post along with the comment for the repost, and an indicator like "(2 reposts)". With this change, it shows something like the following where "mytitle" is the title of the original post with its body.  The second commit updates existing tests to have the correct expected output. The third commit adds a tests for `CreateRepost` with an expected output and errors. (Why did we bother with fixing reposts? Because we implemented reposts in GnoSocial which is a modification of r/demo/boards. Since we fixed this in GnoSocial it's easy to contribute the same fix here, and maybe get some good feedback on the approach.) <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description --------- Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r/demo/boards already implements the data structures for reposts and the API function CreateRepost. But the Render display doesn't handle reposts correctly. I did a repost on test3 with:
This should display on board number 3 "boardtest". https://test3.gno.land/r/demo/boards:boardtest . Indeed, it shows
But when I click on the date to see the post, the page shows "reply does not exist with id: 2" because Render incorrectly treats a repost as a reply.
This pull request is one approach to displaying reposts. It has three commits. The first commit adds
GetRepostFormURL(similar toGetReplyFormURL) and updatesRenderPostwith a helper for [repost] (similar to [reply]). It also updatesRenderSummaryto check if the post is a repost and displays the reposted post along with the comment for the repost, and an indicator like "(2 reposts)". With this change, it shows something like the following where "mytitle" is the title of the original post with its body.The second commit updates existing tests to have the correct expected output.
The third commit adds a tests for
CreateRepostwith an expected output and errors.(Why did we bother with fixing reposts? Because we implemented reposts in GnoSocial which is a modification of r/demo/boards. Since we fixed this in GnoSocial it's easy to contribute the same fix here, and maybe get some good feedback on the approach.)
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description