Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keys/client): prompt user for key name when not provided by user #1540

Closed
wants to merge 2 commits into from

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Jan 16, 2024

Refer to #1492 comment

it would be cool to prompt the user for the key name if it's not specified (not in this PR).

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@Halimao Halimao requested review from jaekwon and moul as code owners January 16, 2024 17:09
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (851a1ae) 55.91% compared to head (183ccce) 55.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1540   +/-   ##
=======================================
  Coverage   55.91%   55.91%           
=======================================
  Files         431      431           
  Lines       65680    65680           
=======================================
+ Hits        36722    36727    +5     
+ Misses      26080    26076    -4     
+ Partials     2878     2877    -1     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl requested a review from zivkovicmilos January 17, 2024 18:01
@thehowl
Copy link
Member

thehowl commented Jan 17, 2024

@zivkovicmilos tagging you as a reviewer to make sure it's what you wanted, ping me if you want me to do a second review + merge afterwards

@zivkovicmilos zivkovicmilos requested a review from gfanton January 18, 2024 10:51
@zivkovicmilos
Copy link
Member

@zivkovicmilos tagging you as a reviewer to make sure it's what you wanted, ping me if you want me to do a second review + merge afterwards

I think you meant to tag @gfanton :)

I see the confusion, but Guilhem has a cooler beard.

I'll take a look at this PR, thank you for the ping 🙏

@thehowl
Copy link
Member

thehowl commented Jan 18, 2024

I see the confusion, but Guilhem has a cooler beard.

Agreed. Apologies, lord of the Beard @gfanton 🙏

@thehowl thehowl changed the title feat: add promption to ask for input key name when user doesn't provide feat(keys/client): prompt user for key name when not provided by user Jan 18, 2024
@gfanton
Copy link
Member

gfanton commented Jan 22, 2024

@Halimao I'm really sorry, but after an internal discussion with the team, we've decided not to merge this. Except for the password, we will not prompt the user for anything and prefer the use of flags as the single source of input.
Again, I apologize for this, especially since it was a suggestion of mine.

@gfanton gfanton closed this Jan 22, 2024
@Halimao
Copy link
Contributor Author

Halimao commented Jan 22, 2024

@Halimao I'm really sorry, but after an internal discussion with the team, we've decided not to merge this. Except for the password, we will not prompt the user for anything and prefer the use of flags as the single source of input.

Again, I apologize for this, especially since it was a suggestion of mine.

It's fine😄

@Halimao Halimao deleted the feat/prompt branch January 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants