Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix noop logger reference #1586

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR fixes the noop log reference that was broken in #1574, after the #1302 PR was merged in earlier.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos requested a review from thehowl January 25, 2024 18:11
@zivkovicmilos zivkovicmilos self-assigned this Jan 25, 2024
@zivkovicmilos zivkovicmilos requested a review from moul as a code owner January 25, 2024 18:11
@zivkovicmilos zivkovicmilos requested a review from gfanton January 25, 2024 18:11
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 25, 2024
@thehowl thehowl merged commit b619351 into gnolang:master Jan 25, 2024
66 of 68 checks passed
@zivkovicmilos zivkovicmilos deleted the hotfix/noop-logger-test branch January 25, 2024 18:12
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Jan 31, 2024
## Description

This PR fixes the `noop` log reference that was broken in
gnolang#1574, after the gnolang#1302 PR was merged
in earlier.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants