Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use action to validate dependabot.yml #1642

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 8, 2024

following this comment from @kristovatlas

This action seems to only validate the JSON schema. For full validation, it's on GitHub to provide this -- tracked in this issue: dependabot/dependabot-core#4605

@thehowl thehowl requested a review from kristovatlas February 8, 2024 15:25
@thehowl thehowl requested review from moul and a team as code owners February 8, 2024 15:25
Copy link

github-actions bot commented Feb 8, 2024

✅dependabot config looks good 👍

@thehowl
Copy link
Member Author

thehowl commented Feb 8, 2024

Actually, awful. I don't want this as a comment. I'll see if it can be improved somehow by just having the CI check instead.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (846956f) 56.50% compared to head (d22273c) 56.10%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
- Coverage   56.50%   56.10%   -0.41%     
==========================================
  Files         439      439              
  Lines       66559    66214     -345     
==========================================
- Hits        37608    37148     -460     
- Misses      26026    26173     +147     
+ Partials     2925     2893      -32     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kristovatlas
Copy link
Contributor

Thanks for giving it a shot even though you're not digging the comment feature!

@thehowl
Copy link
Member Author

thehowl commented Feb 9, 2024

Thanks for giving it a shot even though you're not digging the comment feature!

This is fixed, with the new commits it now just makes the CI red :)

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some automated check that GitHub does for Dependabot changes, but it's not an active CI check on the PR itself, so this looks good 💯

@thehowl thehowl merged commit 91aa2af into master Feb 22, 2024
183 of 184 checks passed
@thehowl thehowl deleted the dev/morgan/dependabot-verify branch February 22, 2024 17:43
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
following [this
comment](gnolang#1628 (comment))
from @kristovatlas

This action seems to only validate the JSON schema. For full validation,
it's on GitHub to provide this -- tracked in this issue:
dependabot/dependabot-core#4605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants