Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stdlibs): remove unused internal/os #1678

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 22, 2024

This package is entirely unused, should have been removed in the first native bindings PR.

@thehowl thehowl self-assigned this Feb 22, 2024
@thehowl thehowl requested a review from jaekwon as a code owner February 22, 2024 11:22
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (989e6d6) 47.41% compared to head (27acf65) 47.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1678   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files         385      385           
  Lines       61320    61320           
=======================================
  Hits        29074    29074           
  Misses      29827    29827           
  Partials     2419     2419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 0b39151 into master Feb 22, 2024
188 of 189 checks passed
@thehowl thehowl deleted the dev/morgan/rm-internal-os branch February 22, 2024 17:47
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
This package is entirely unused, should have been removed in the first
native bindings PR.

Co-authored-by: Guilhem Fanton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants