fix: top sort var/const globals #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-dambovaliev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 47.49% 45.03% -2.47%
==========================================
Files 388 464 +76
Lines 61305 68076 +6771
==========================================
+ Hits 29117 30655 +1538
- Misses 29750 34850 +5100
- Partials 2438 2571 +133 ☔ View full report in Codecov by Sentry. |
petar-dambovaliev
requested review from
jaekwon,
piux2,
thehowl and
moul
as code owners
petar-dambovaliev
requested review from
zivkovicmilos
and removed request for
thehowl
zivkovicmilos
approved these changes
Apr 8, 2024
|
Pinged @deelawn / @ajnavarro for a second look 🙏 |
ajnavarro
reviewed
Apr 8, 2024
thehowl
added a commit
that referenced
this pull request
Apr 24, 2024
per discussion with @jaekwon; see #1854 (comment)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this and this.
Before preprocessing, a dependency graph is created and edges between the nodes which represent the relationship between global
varandconstdeclarations.Then, a new slice of declarations is created that is topologically sorted.
This enables the rest of the preprocessing code to work the way it is now.
Small scale refactoring is included by removing unnecessary else statements in
PredefineFileSet.