refactor: use stretchr/testify throughout codebase
#1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🤖 gnovm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1931 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 464 464
Lines 68008 68008
=======================================
+ Hits 30652 30656 +4
+ Misses 34781 34778 -3
+ Partials 2575 2574 -1 ☔ View full report in Codecov by Sentry. |
harry-hov
commented
Apr 15, 2024
harry-hov
requested review from
thehowl,
a team,
moul,
gfanton,
jaekwon,
piux2 and
zivkovicmilos
as code owners
thehowl
approved these changes
Apr 18, 2024
3 tasks
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
Currently, we use 2 implementations of testify in our codebase - `jaekwon/testify` and `stretchr/testify` To streamline our practices and minimize confusion, it's a good idea to opt for a single implementation. After discussion, we all agreed on using `stretchr/testify` throughout our codebase. Closes gnolang#777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use 2 implementations of testify in our codebase -
jaekwon/testifyandstretchr/testifyTo streamline our practices and minimize confusion, it's a good idea to opt for a single implementation.
After discussion, we all agreed on using
stretchr/testifythroughout our codebase.Closes #777