fix: use atomic for global counter used for parallel testing #1932
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `go test -race` to pass on`gnovm/pkg/gnolang` when run in parallel mode with CPU > 1. As we use lockless atomic instructions there should be no overhead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
+ Coverage 45.07% 45.08% +0.01%
==========================================
Files 464 464
Lines 68008 68000 -8
==========================================
+ Hits 30652 30659 +7
+ Misses 34781 34769 -12
+ Partials 2575 2572 -3 ☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
Apr 16, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 16, 2024
…#1932) This allows `go test -race` to pass on`gnovm/pkg/gnolang` when run in parallel mode with CPU > 1. As we use lockless atomic instructions there should be no overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
go test -raceto pass ongnovm/pkg/gnolangwhen run in parallel mode with CPU > 1.As we use lockless atomic instructions there should be no overhead.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description