Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty timestamp from the tx signature payload #1939

Merged
merged 7 commits into from
Apr 29, 2024

Merge branch 'master' into fix/standardize-tx-sig

11ad828
Select commit
Loading
Failed to load commit list.
Merged

fix: remove empty timestamp from the tx signature payload #1939

Merge branch 'master' into fix/standardize-tx-sig
11ad828
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2024 in 0s

46.67% (+0.02%) compared to 7bf662a

View this Pull Request on Codecov

46.67% (+0.02%) compared to 7bf662a

Details

Codecov Report

Attention: Patch coverage is 70.14925% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 46.67%. Comparing base (7bf662a) to head (11ad828).

Files Patch % Lines
tm2/pkg/std/tx.go 0.00% 9 Missing ⚠️
tm2/pkg/std/doc.go 57.14% 2 Missing and 1 partial ⚠️
gno.land/pkg/gnoclient/signer.go 33.33% 1 Missing and 1 partial ⚠️
tm2/pkg/crypto/keys/client/sign.go 77.77% 1 Missing and 1 partial ⚠️
tm2/pkg/sdk/auth/ante.go 84.61% 1 Missing and 1 partial ⚠️
tm2/pkg/std/utils.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   46.64%   46.67%   +0.02%     
==========================================
  Files         492      492              
  Lines       69624    69657      +33     
==========================================
+ Hits        32476    32510      +34     
+ Misses      34442    34435       -7     
- Partials     2706     2712       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.