Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more telemetry #2059

Merged
merged 21 commits into from
May 24, 2024

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented May 8, 2024

Description

Closes #1829

This PR introduces new metrics for different TM2 modules, as outlined in #1829.

Thank you @gfanton and @ajnavarro for helping out with the Docker issues 🙏

How do I test this out?

Head over to misc/telemetry and follow the README -- you can run everything locally in Docker 😎

grafana-2

cc @mazzy89

Metrics added

Consensus

  • block interval (time between current and prev block in seconds)
  • number of transactions in the latest block
  • block size (in bytes)
  • number of validators
  • total voting power of the validator set

Networking

  • number of inbound peers
  • number of outbound peers
  • number of pending peers (dialing)

JSON-RPC

  • response time for requests (http / ws)

Mempool

  • number of valid txs in the mempool
  • number of txs in the mempool cache

VM

  • gas used per execution
  • CPU cycles
  • different VM query message call frequency
  • different VM execution frequency (run, call, addpkg)
  • VM query error frequency
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels May 8, 2024
@zivkovicmilos zivkovicmilos requested a review from deelawn May 8, 2024 18:18
@zivkovicmilos zivkovicmilos self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 17.51825% with 226 lines in your changes are missing coverage. Please review.

Project coverage is 48.98%. Comparing base (c6cde63) to head (416819a).

Files Patch % Lines
tm2/pkg/telemetry/metrics/metrics.go 0.00% 123 Missing ⚠️
gno.land/pkg/sdk/vm/handler.go 0.00% 29 Missing ⚠️
tm2/pkg/bft/rpc/lib/server/handlers.go 9.67% 26 Missing and 2 partials ⚠️
gno.land/pkg/sdk/vm/keeper.go 64.28% 15 Missing ⚠️
tm2/pkg/bft/consensus/state.go 28.57% 10 Missing ⚠️
tm2/pkg/telemetry/init.go 0.00% 8 Missing ⚠️
tm2/pkg/bft/mempool/clist_mempool.go 41.66% 7 Missing ⚠️
tm2/pkg/p2p/switch.go 50.00% 4 Missing ⚠️
gno.land/cmd/gnoland/start.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   49.14%   48.98%   -0.17%     
==========================================
  Files         576      576              
  Lines       77616    77736     +120     
==========================================
- Hits        38148    38078      -70     
- Misses      36377    36568     +191     
+ Partials     3091     3090       -1     
Flag Coverage Δ
gno.land 61.38% <36.98%> (-0.31%) ⬇️
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.53% <10.44%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx
Copy link
Member

albttx commented May 9, 2024

please watch #2032

@zivkovicmilos zivkovicmilos marked this pull request as ready for review May 13, 2024 18:15
@zivkovicmilos zivkovicmilos requested review from a team, moul, gfanton and thehowl as code owners May 13, 2024 18:15
@zivkovicmilos zivkovicmilos requested review from a team, jaekwon and piux2 as code owners May 13, 2024 18:15
@zivkovicmilos zivkovicmilos requested a review from ajnavarro May 13, 2024 18:15
gno.land/pkg/sdk/vm/handler.go Show resolved Hide resolved
gno.land/pkg/sdk/vm/keeper.go Show resolved Hide resolved
tm2/pkg/p2p/test_util.go Show resolved Hide resolved
@zivkovicmilos zivkovicmilos requested a review from deelawn May 24, 2024 11:49
@zivkovicmilos zivkovicmilos merged commit 90aa89c into gnolang:master May 24, 2024
59 of 63 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/improve-telemetry branch May 24, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[tm2] Node Metrics
5 participants