-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Implement p/demo/nonces #2123
Conversation
return currentNonce | ||
} | ||
|
||
// UseCheckedNonce consumes a nonce if it matches the expected value, otherwise returns an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain how you intend to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a necessary additional check before actually consuming the nonce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing your pull requests is challenging. Please avoid marking conversations as resolved on your own. Instead, focus on addressing the issues or providing responses so we can more easily conduct a second review.
cc @gnolang/devrels @zivkovicmilos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your answer. Can you provide a better explanation? An example?
Co-authored-by: Manfred Touron <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>
Can you provide some usage examples for this package? I see a pattern of using a |
For sure, demo is here #2225 Actually, the name |
Description
From issue : #2119
A simple implementation of nonce manager in p/demo/nonces : Provides tracking nonces for addresses. Nonces will only increment.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description