-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace all occurence of port 3665{6,7,8} to 2665{6,7,8} #2178
Conversation
Will update depending on CI response |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2178 +/- ##
==========================================
+ Coverage 49.00% 49.33% +0.32%
==========================================
Files 576 576
Lines 77581 78336 +755
==========================================
+ Hits 38022 38650 +628
- Misses 36476 36568 +92
- Partials 3083 3118 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @moul
@thehowl is this test failing "normal" https://github.com/gnolang/gno/actions/runs/9210109774/job/25336315992?pr=2178 |
@albttx didn't finish the comment, but no it's not normal the test is bad (it does an actual connection to the actual test3 node, we are aware), you should probably makes sure it keeps connecting to 36657... |
@thehowl Deploying with https://github.com/gnolang/gno/pull/2178/files#diff-4d1103f730f8cf1eb77c7f7f1ccb5b28bd0eabd3d9bebd10e459a3fdb6ebae64R30 should do the trick ;) I can do it if you want :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the code for supporting both 26657 and 36657 on test3.
Since both are going to be supported, please revert the changes in gnovm/pkg/gnomod/file_test.go
The primary reason, iirc, was not to run multiple services on the same server but to clearly distinguish between a production instance and a development instance. It should be okay to consolidate this and depend solely on hosts and chain ID. |
@moul Ok, i thought it was the reasons. Nonetheless i believe the RPC port should never be exposed publicly without a proxy in front. |
…ang#2178) ``` s/36657/26657/g ``` I believe the port 36657 come because there was multiple testnet on the same server, so the port have been put to 36657. `tendermint` default port is `266*` and i believe we should keep everything conform to it. I let test3 compatible with 26657 AND 36657 for legacy purpose <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
I believe the port 36657 come because there was multiple testnet on the same server, so the port have been put to 36657.
tendermint
default port is266*
and i believe we should keep everything conform to it.I let test3 compatible with 26657 AND 36657 for legacy purpose
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description