Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace all occurence of port 3665{6,7,8} to 2665{6,7,8} #2178

Merged
merged 5 commits into from
May 27, 2024

Conversation

albttx
Copy link
Member

@albttx albttx commented May 23, 2024

s/36657/26657/g

I believe the port 36657 come because there was multiple testnet on the same server, so the port have been put to 36657.

tendermint default port is 266* and i believe we should keep everything conform to it.

I let test3 compatible with 26657 AND 36657 for legacy purpose

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels May 23, 2024
@albttx albttx changed the title chore: remove all occurence of port 36657 to 26657 chore: remove all occurence of port 3665{6,7} to 2665{6,7} May 23, 2024
@albttx
Copy link
Member Author

albttx commented May 23, 2024

Will update depending on CI response

@zivkovicmilos zivkovicmilos requested a review from ajnavarro May 23, 2024 14:47
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.33%. Comparing base (e4b39f9) to head (92dffc5).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2178      +/-   ##
==========================================
+ Coverage   49.00%   49.33%   +0.32%     
==========================================
  Files         576      576              
  Lines       77581    78336     +755     
==========================================
+ Hits        38022    38650     +628     
- Misses      36476    36568      +92     
- Partials     3083     3118      +35     
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (+0.03%) ⬆️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.56% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @moul

@albttx
Copy link
Member Author

albttx commented May 23, 2024

@albttx albttx changed the title chore: remove all occurence of port 3665{6,7} to 2665{6,7} chore: replace all occurence of port 3665{6,7,8} to 2665{6,7,8} May 23, 2024
@thehowl
Copy link
Member

thehowl commented May 23, 2024

@albttx didn't finish the comment, but no it's not normal

the test is bad (it does an actual connection to the actual test3 node, we are aware), you should probably makes sure it keeps connecting to 36657...

@albttx
Copy link
Member Author

albttx commented May 24, 2024

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the code for supporting both 26657 and 36657 on test3.

Since both are going to be supported, please revert the changes in gnovm/pkg/gnomod/file_test.go

Dockerfile.gnoland.release Show resolved Hide resolved
@moul
Copy link
Member

moul commented May 24, 2024

The primary reason, iirc, was not to run multiple services on the same server but to clearly distinguish between a production instance and a development instance. It should be okay to consolidate this and depend solely on hosts and chain ID.

@albttx
Copy link
Member Author

albttx commented May 27, 2024

The primary reason, iirc, was not to run multiple services on the same server but to clearly distinguish between a production instance and a development instance. It should be okay to consolidate this and depend solely on hosts and chain ID.

@moul Ok, i thought it was the reasons. Nonetheless i believe the RPC port should never be exposed publicly without a proxy in front.

@thehowl thehowl merged commit 8de4c31 into master May 27, 2024
82 of 83 checks passed
@thehowl thehowl deleted the update-default-port-26657 branch May 27, 2024 13:49
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
…ang#2178)

```
s/36657/26657/g
```

I believe the port 36657 come because there was multiple testnet on the
same server, so the port have been put to 36657.

`tendermint` default port is `266*` and i believe we should keep
everything conform to it.

I let test3 compatible with 26657 AND 36657 for legacy purpose

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants