feat(stdlibs): add math/rand #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @leohhhn |
thehowl
requested review from
jaekwon,
deelawn,
mvertes,
moul and
a team
as code owners
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
+ Coverage 54.68% 54.71% +0.03%
==========================================
Files 583 583
Lines 78503 78499 -4
==========================================
+ Hits 42930 42952 +22
+ Misses 32364 32341 -23
+ Partials 3209 3206 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
requested review from
ajnavarro,
a team,
gfanton,
piux2 and
zivkovicmilos
as code owners
deelawn
approved these changes
Jun 28, 2024
mvertes
reviewed
Jun 28, 2024
ajnavarro
approved these changes
Jun 28, 2024
moul
added a commit
to moul/gno
that referenced
this pull request
Jul 3, 2024
This reverts commit f547d7d.
This was referenced Jul 3, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
This PR ports over to Gno the [math/rand/v2](https://pkg.go.dev/math/rand/v2) Go package. It provides pseudo-random number generation. Notable omissions: - the [`N` generic function](https://pkg.go.dev/math/rand/[email protected]#N) - The [chacha8 random source](https://pkg.go.dev/math/rand/[email protected]#ChaCha8) (we can use PCG instead; and chacha8 can be implemented later) This PR requires a version bump to go 1.22 to have math/rand/v2 in the standard libraries; otherwise the Native tests won't work. We can rollback the changes to move it to 1.22 by removing the native math/rand implementation, and only using the stdlibs. BREAKING CHANGE: existing usages of math/rand used Go's math/rand; however, in this new standard library we use its v2, so results will be different. Closes gnolang#1272; See-also gnolang#1267 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
moul
added a commit
that referenced
this pull request
Aug 9, 2024
- Revert partially "feat(stdlibs): add math/rand (#2455) (f547d7d) - Update p/demo/rand and rename to p/demo/entropy --------- Signed-off-by: moul <[email protected]> Co-authored-by: Marc Vertes <[email protected]>
MikaelVallenet
pushed a commit
to MikaelVallenet/gno
that referenced
this pull request
Aug 17, 2024
- Revert partially "feat(stdlibs): add math/rand (gnolang#2455) (f547d7d) - Update p/demo/rand and rename to p/demo/entropy --------- Signed-off-by: moul <[email protected]> Co-authored-by: Marc Vertes <[email protected]>
linhpn99
pushed a commit
to linhpn99/gno
that referenced
this pull request
Aug 20, 2024
- Revert partially "feat(stdlibs): add math/rand (gnolang#2455) (f547d7d) - Update p/demo/rand and rename to p/demo/entropy --------- Signed-off-by: moul <[email protected]> Co-authored-by: Marc Vertes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over to Gno the math/rand/v2 Go package. It provides pseudo-random number generation.
Notable omissions:
Ngeneric functionThis PR requires a version bump to go 1.22 to have math/rand/v2 in the standard libraries; otherwise the Native tests won't work. We can rollback the changes to move it to 1.22 by removing the native math/rand implementation, and only using the stdlibs.
BREAKING CHANGE: existing usages of math/rand used Go's math/rand; however, in this new standard library we use its v2, so results will be different.
Closes #1272; See-also #1267
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description