feat(examples): refactor grc20 #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
moul
requested review from
gfanton,
petar-dambovaliev,
leohhhn and
r3v4s
and removed request for
a team
r3v4s
reviewed
Jul 7, 2024
|
Seems like docs needs to be changed too. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 54.92% 54.91% -0.01%
==========================================
Files 594 594
Lines 79297 79297
==========================================
- Hits 43550 43546 -4
- Misses 32456 32459 +3
- Partials 3291 3292 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
moul
added a commit
that referenced
this pull request
Jul 7, 2024
- add 'make build' (embedmd) - refactor Makefile (simplified) - check on CI that docs/ is "built" (no diff) Related (but not closing) #2532 Part of #2529 --------- Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@r3v4s fixed, thank you. |
Signed-off-by: moul <[email protected]>
|
lgtm |
leohhhn
approved these changes
Jul 7, 2024
|
I also want to implement the banker/safetoken stuff in my PR - don't want to scrape that one. Do you think we can have a |
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
- add 'make build' (embedmd) - refactor Makefile (simplified) - check on CI that docs/ is "built" (no diff) Related (but not closing) gnolang#2532 Part of gnolang#2529 --------- Signed-off-by: moul <[email protected]>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Main changes: - rename `AdminToken` -> `Banker` - rename `GRC20` -> `Token` - remove unused helpers - remove vault (temporarily, will be reimplemented) - remove the returner ˋerror` when unnecessary - use `std.Emit` - use uassert for testing - better file naming and organization for improved readability Fixes gnolang#2294 Replaces gnolang#2314 (h/t @leohhhn) ~Depends on gnolang#2534~ BREAKING CHANGE --------- Signed-off-by: moul <[email protected]> Co-authored-by: Leon Hudak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
AdminToken->BankerGRC20->Tokenstd.EmitFixes #2294
Replaces #2314 (h/t @leohhhn)
Depends on #2534BREAKING CHANGE