feat(examples): forms #2604

agherasie · 2024-07-18T18:12:16Z

As part of the student contributor program, I attempted to create a new example realm that allows the creation and submission of forms on gno !

Features

Form Creation: Create new forms with specified titles, descriptions, and fields.
CreateForm(...)
Form Submission: Submit answers to forms.
SubmitForm(...)
Form Retrieval: Retrieve existing forms and their submissions.
GetForms(...), GetFormByID(...), GetAnswer(...)
Form Deadline: Set a precise time range during which a form can be interacted with.

Field Types

The system supports the following field types:

type	example
string	`{"label": "Name", "fieldType": "string", "required": true}`
number	`{"label": "Age", "fieldType": "number", "required": true}`
boolean	`{"label": "Is Student?", "fieldType": "boolean", "required": false}`
choice	`{"label": "Favorite Food", "fieldType": "[Pizza
multi-choice	`{"label": "Hobbies", "fieldType": "{Reading

Demo

The external repo where the initial development took place and where you can find the frontend is here.

The web app itself is hosted here

And the most recent test4 version of the contract is forms2

Screenshots :

gnoweb Render()

a form response in the web interface

creating a form in the web interface

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

codecov · 2024-07-18T18:28:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

leohhhn

Thanks for this PR! I've left some comments, try to address them 🙏

examples/gno.land/p/demo/forms/forms.gno

examples/gno.land/p/demo/forms/create.gno

examples/gno.land/p/demo/forms/create_test.gno

examples/gno.land/p/demo/forms/forms.gno

examples/gno.land/p/demo/forms/submit_test.gno

Co-authored-by: Leon Hudak <[email protected]>

gfanton

sgtm (after formatting the markdown table)

examples/gno.land/p/demo/forms/README.md

examples/gno.land/p/demo/forms/create.gno

examples/gno.land/p/demo/forms/forms.gno

Co-authored-by: Guilhem Fanton <[email protected]>

thehowl · 2024-10-04T13:33:57Z

@leohhhn @gfanton do you think this can be merged or do you want another review?

jefft0 · 2024-10-04T14:03:50Z

Removed the "review team" label because this is already reviewed by core devs.

ltzmaxwell · 2024-10-04T14:07:42Z

examples/gno.land/p/demo/forms/create.gno

+type times struct {
+	openAt  *time.Time
+	closeAt *time.Time
+}
+
+func parseDates(openAt string, closeAt string) (times, error) {
+	var openAtTime, closeAtTime *time.Time
+
+	const dateFormat = "2006-01-02T15:04:05Z"
+
+	// Parse openAt if it's not empty
+	if openAt != "" {
+		res, err := time.Parse(dateFormat, openAt)
+		if err != nil {
+			return times{}, errInvalidDate
+		}
+		openAtTime = &res
+	}
+
+	// Parse closeAt if it's not empty
+	if closeAt != "" {
+		res, err := time.Parse(dateFormat, closeAt)
+		if err != nil {
+			return times{}, errInvalidDate
+		}
+		closeAtTime = &res
+	}
+
+	return times{openAtTime, closeAtTime}, nil
+}


this(times) seems to be a redundant design;

using time.Time directly (without a pointer) is perfectly fine.
@leohhhn

github-actions · 2025-01-04T01:58:34Z

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

Gno2D2 · 2025-01-14T04:27:19Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: agherasie/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

thehowl · 2025-01-14T17:55:29Z

Alas, author seems unresponsive. @agherasie, feel free to re-open this PR and bring it up to date also in the CI and I'll try to get it merged.

agherasie · 2025-01-15T19:20:34Z

Alas, author seems unresponsive. @agherasie, feel free to re-open this PR and bring it up to date also in the CI and I'll try to get it merged.

Hi @thehowl , sorry for taking so long to update !
I just opened #3524 with small fixes for the CI + an earlier review comment that was left unaddressed !
I'd love to get the PR merged and am open to any new suggestions big or small in case it's not considered ready for merging yet !

agherasie added 5 commits July 16, 2024 19:59

feat(examples): gno-forms

47d5d84

chore: fmt gno-forms

a19037a

feat(examples): gno-forms readme and comments

34c23eb

feat(examples): r/forms date restrictions

1ac3eeb

chore(examples): fmt

332d856

github-actions bot assigned agherasie Jul 18, 2024

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 18, 2024

leohhhn marked this pull request as ready for review July 21, 2024 00:07

leohhhn requested review from a team as code owners July 21, 2024 00:07

leohhhn requested review from jaekwon and gfanton and removed request for a team July 21, 2024 00:07

leohhhn approved these changes Jul 21, 2024

View reviewed changes

agherasie and others added 12 commits July 21, 2024 11:41

Update examples/gno.land/p/demo/forms/submit_test.gno

92797f1

Co-authored-by: Leon Hudak <[email protected]>

Update examples/gno.land/p/demo/forms/create_test.gno

82dd483

Co-authored-by: Leon Hudak <[email protected]>

fix(examples): newlines in gno-forms structs

9504f6f

fix(examples): FormDB rename gno-forms

254c10f

fix(examples): gno-forms unexported functions

76afc46

fix(examples): gno-forms error constants

6e35760

fix(examples): gno-forms handling all invalid json errors

f0a0e58

feat(examples): gno-forms using urequire

8d97b6d

chore(examples): gno-forms fmt

c6f0b15

chore(examples): gno-forms godoc

361170a

chore(examples): gno-forms tidy

2588cb3

Merge branch 'master' into feat/gno-forms

e9fb754

agherasie mentioned this pull request Jul 22, 2024

PoC Innovation - Student Program Journey gnolang/hackerspace#68

Open

agherasie added 2 commits July 30, 2024 18:59

Update README.md

9ccffcf

Merge branch 'master' into feat/gno-forms

9d5f76b

gfanton approved these changes Aug 2, 2024

View reviewed changes

examples/gno.land/p/demo/forms/README.md Outdated Show resolved Hide resolved

examples/gno.land/p/demo/forms/create.gno Outdated Show resolved Hide resolved

examples/gno.land/p/demo/forms/forms.gno Outdated Show resolved Hide resolved

agherasie and others added 4 commits August 2, 2024 18:10

Update examples/gno.land/p/demo/forms/forms.gno

f4e7378

Co-authored-by: Guilhem Fanton <[email protected]>

Update examples/gno.land/p/demo/forms/create.gno

8da6592

Co-authored-by: Guilhem Fanton <[email protected]>

chore(examples): gno forms readme markdown table formatting

10e6843

Merge branch 'master' into feat/gno-forms

854d61b

leohhhn mentioned this pull request Aug 4, 2024

Minutes: SCP Updates [every Monday] gnolang/meetings#39

Open

Merge branch 'master' into feat/gno-forms

39c8bcb

agherasie requested review from leohhhn and gfanton August 16, 2024 15:26

Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024

jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 4, 2024

ltzmaxwell reviewed Oct 4, 2024

View reviewed changes

Kouteki mentioned this pull request Oct 8, 2024

Minutes: Core Staff Weekly Syncs [every Monday] gnolang/meetings#36

Open

github-actions bot added Stale and removed Stale labels Jan 4, 2025

Merge branch 'master' into feat/gno-forms

d11bff6

thehowl closed this Jan 14, 2025

This was referenced Jan 15, 2025

feat(examples): forms #2 agherasie/gno#3

Open

feat(examples): forms #2 #3524

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(examples): forms #2604

feat(examples): forms #2604

agherasie commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

leohhhn left a comment

gfanton left a comment

thehowl commented Oct 4, 2024

jefft0 commented Oct 4, 2024

ltzmaxwell Oct 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2025

Gno2D2 commented Jan 14, 2025

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

If

Can be checked by

thehowl commented Jan 14, 2025

agherasie commented Jan 15, 2025

feat(examples): forms #2604

feat(examples): forms #2604

Conversation

agherasie commented Jul 18, 2024 • edited Loading

Features

Field Types

Demo

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

leohhhn left a comment

Choose a reason for hiding this comment

gfanton left a comment

Choose a reason for hiding this comment

thehowl commented Oct 4, 2024

jefft0 commented Oct 4, 2024

ltzmaxwell Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 4, 2025

Gno2D2 commented Jan 14, 2025

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

If

Can be checked by

thehowl commented Jan 14, 2025

agherasie commented Jan 15, 2025

agherasie commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

ltzmaxwell Oct 4, 2024 •

edited

Loading