-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TotalCoin implementation #2670
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2670 +/- ##
==========================================
- Coverage 60.11% 60.09% -0.03%
==========================================
Files 560 560
Lines 74918 74925 +7
==========================================
- Hits 45039 45027 -12
- Misses 26504 26519 +15
- Partials 3375 3379 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @leohhhn , when you have a bit of time, could you check my code please For the moment, I've put my PR in draft form because I don't think my approach is the right one for these reasons:
I realised this when I saw the PR for @thinhnx-var |
I did not see this PR after I looked at the original issue again. Thats why I pushed my PR @DIGIX666. 🙏 |
No problem, I should have asked if someone was working on it first ;) |
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
Added TotalCoin implementation to take into account the total of a specific coin based on its denomination.
This should solve #2662
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description