-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: p/zteams implementation #2830
base: master
Are you sure you want to change the base?
feat: p/zteams implementation #2830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=======================================
Coverage 61.10% 61.11%
=======================================
Files 564 564
Lines 75355 75355
=======================================
+ Hits 46045 46050 +5
+ Misses 25945 25943 -2
+ Partials 3365 3362 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you, Dragos. Please review issue #2195. The primary goal is to create the The Feel free to continue working on this version if you wish, but we cannot review it until we complete at least the interfaces for I’m converting your PR to draft for now. However, feel free to mark it as ready for review if you believe it would be beneficial for the project to be reviewed again. |
Thank you, Manfred I reviewed the #2195 issue and I understand now the goal of creating However, I think going forward with my implementation can have some benefits. The main reason behind making such a package in the first place was my work on ZenTasktic, specifically the I'm thinking about renaming this as
I'm also thinking about getting read of the Instead, I'll add a I'll mark it as ready for review when this is done. Hope this is ok. |
I'm asking for a re-review of this because I'm working on a zentasktic_project implementation which uses this package for team & user management. I already finished it on my local dev env, and I would like to move on with deploying on the public testnet. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it looks good, but I've left a few suggestions for improvement. Please review and address them. Thank you!
Everything looks good to me. For the finishing, could you run fmt again? The action is showing as failed. thank you |
Done, looks like tests are passing. |
Removed the "review/triage-pending" label because notJoon approved and this is ready for core dev review. |
An alternative team package implementation. Primarily inspired by building the ZenTasktic framework.