-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to execute filetests with prefix #2837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
=======================================
Coverage 60.85% 60.85%
=======================================
Files 563 563
Lines 75193 75193
=======================================
+ Hits 45757 45759 +2
+ Misses 26069 26066 -3
- Partials 3367 3368 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
can we also have this for txtar? |
We can but I'd prefer not to do it in this PR. |
LGTM. can we add one or two examples to use the flag for filetests in the description? |
Yes, of course, 👍 |
What's wrong with |
Nothing is wrong with that. It's just convenient for running tests and debugging. VS Code allows to run tests from right in the editor, as well as running in debug mode so users can set certain breakpoints for a suite of tests. I found myself adding this locally multiple times when diagnosing various issues, so it would probably be useful to others as well. |
Skipping to avoid redundancy with -run. |
This simply allows a prefix to be set when running filetests so that only a subset of tests are executed. This is especially useful when a PR requires many new filetests -- it allows execution of all new tests without having to wait for ALL tests to run.