Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add moul/ulist #3407

Merged
merged 3 commits into from
Dec 31, 2024
Merged

feat(examples): add moul/ulist #3407

merged 3 commits into from
Dec 31, 2024

Conversation

moul
Copy link
Member

@moul moul commented Dec 25, 2024

Replaces #3402
Related with #3321

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 25, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 25, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul marked this pull request as draft December 25, 2024 21:46
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 27, 2024
@moul moul force-pushed the dev/moul/ulist3 branch 3 times, most recently from ed2b486 to 87f6a78 Compare December 27, 2024 20:30
@moul moul force-pushed the dev/moul/ulist3 branch 4 times, most recently from 4c1e7bf to 9571197 Compare December 27, 2024 22:31
@moul moul marked this pull request as ready for review December 27, 2024 22:35
@moul moul mentioned this pull request Dec 28, 2024
2 tasks
Signed-off-by: moul <[email protected]>
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a concise and perfect implementation. LGTM 👍

@moul moul merged commit beb48e7 into gnolang:master Dec 31, 2024
17 checks passed
@moul moul deleted the dev/moul/ulist3 branch December 31, 2024 08:55
albttx pushed a commit that referenced this pull request Jan 10, 2025
- [x] Depends on #3404 (cherry-picked)

Replaces #3402 
Related with #3321

---------

Signed-off-by: moul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants