Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gnovm/pkg/gnolang): add more diverse Go programs to FuzzParseFile #3511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odeke-em
Copy link
Contributor

This change involves bringing in Go programs from the latest Go master tree by downloading them afresh, instead of committing 35+MB to this repo's Git history.
The diversity in the Go programs allows the fuzzer to battle test Go2Gno much better and find divergences so much faster and better.

Updates #3087

This change involves bringing in Go programs from the latest Go master tree
by downloading them afresh, instead of committing 35+MB to this repo's
Git history.
The diversity in the Go programs allows the fuzzer to battle test Go2Gno
much better and find divergences so much faster and better.

Updates gnolang#3087
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jan 14, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 14, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: odeke-em/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl
Copy link
Member

thehowl commented Jan 14, 2025

I don't know, because many of these samples are coming from Go which has more standard libraries and features we don't have, so I worry it may end up doing more harm than good in fuzzing?

Leaving aside that I don't really like tests to require an HTTP download and to be dependent on the state of the Go source code at tip.

@odeke-em
Copy link
Contributor Author

I don't know, because many of these samples are coming from Go which has more standard libraries and features we don't have, so I worry it may end up doing more harm than good in fuzzing?

@thehowl, so Go2Gno as you know and wrote ensures that we can convert written Go programs into Gno. Without high diversity of samples, which this repo lacks, coverage for that functionality is low. Where features aren't supported we shall add an intentional flow exception.

I did explain in my commit message why we are pulling in samples via HTTP call instead of committing 35+MB of a zip file for life into this Git tree. If you'd prefer I can gladly commit it to git.

@thehowl
Copy link
Member

thehowl commented Jan 14, 2025

I'm not convinced it's a right approach though. Are there code paths that are consistently not being inspected through fuzzing? Could we not add smaller samples to the fuzzer?

I'd rather not commit the whole set of files to git; but in general I would avoid using this entire set of files as a sample if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants