feat(boards2): member role management #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to create the default permissions with an empty DAO, simplifying permissions initialization and removing some redundancy.
Both initializations are similar but the permissions are different, for example board creation doesn't exist in board DAOs. Other super DAO permissions won't exist in board DAOs.
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
|
@x1unix this PR is ready for review 🙏 |
jeronimoalbi
commented
Jan 14, 2025
Comment on lines
-36
to
-47
| func (dp DefaultPermissions) Roles() []Role { | ||
| var roles []Role | ||
| if dp.superRole != "" { | ||
| roles = append(roles, dp.superRole) | ||
| } | ||
|
|
||
| dp.roles.Iterate("", "", func(name string, _ interface{}) bool { | ||
| roles = append(roles, Role(name)) | ||
| return false | ||
| }) | ||
| return roles | ||
| } |
There was a problem hiding this comment.
Removed Roles() because it's not being used anymore
jeronimoalbi
commented
Jan 14, 2025
Comment on lines
-137
to
+136
| admindao.New(admindao.WithMember(owner)), | ||
| admindao.New(), |
There was a problem hiding this comment.
Removed member initialization because WithUser(owner, RoleOwner) now adds the user to the DAO if it's not a member.
x1unix
approved these changes
Jan 16, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3171