Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boardsv2): hide flagged comments #3536

Conversation

x1unix
Copy link
Contributor

@x1unix x1unix commented Jan 17, 2025

Description

This PR adjusts display of flagged comments with flow defined in #3480.

Now, flagged comments will be hidden but children replies still be visible.

Demo

image

Important

The "comment is hidden" message is actually italic, but italic font styles are broken in Gnoweb

Other Changes

In addition to that:

  • Fixed Reply URL arguments.
  • Added Flag thread/comment URL.
  • Started adopting strings.Builder instead of string concatenation.

CC @jeronimoalbi

Closes: #3480

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 17, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 17, 2025

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @jeronimoalbi)
  • The pull request description provides enough details (checked by @jeronimoalbi)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gnostudio/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@x1unix x1unix mentioned this pull request Jan 17, 2025
6 tasks
@jeronimoalbi jeronimoalbi merged commit e60574f into gnolang:devx/feature/boardsv2 Jan 17, 2025
21 checks passed
@x1unix x1unix deleted the feat/boards2/3480-comments-flagging branch January 17, 2025 16:28
@salmad3 salmad3 mentioned this pull request Jan 22, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants