Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards2): improve public realm functions #3583

Merged

Conversation

jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Jan 22, 2025

The PR simplifies the implementation of a couple public boards2 realm functions and change them to be up to date with the latest permission handling changes.

These changes also allow a creator of a thread to edit it without permission, or creators of a reply/comment to delete the reply.

Also creators of a thread are allowed to delete it for now. This behavior might change in future PRs.

@jeronimoalbi jeronimoalbi self-assigned this Jan 22, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 22, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 22, 2025

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @jeronimoalbi)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gnostudio/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@@ -188,7 +188,7 @@ func (post *Post) DeleteReply(replyID PostID) error {
return errors.New("reply not found in thread")
}

// TODO: Remove child replies too!
// TODO: Shouldn't reply be hidden instead of deleted? Maybe replace reply by a deleted message.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be solved in a following PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #3606

@jeronimoalbi jeronimoalbi marked this pull request as ready for review January 23, 2025 09:50
@jeronimoalbi
Copy link
Member Author

@x1unix this PR is ready for review 🙏

@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 23, 2025
@jeronimoalbi jeronimoalbi removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 23, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 23, 2025
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 27, 2025
jeronimoalbi added a commit that referenced this pull request Jan 27, 2025
…lies (#3606)

Replies are soft deleted by replacing their body with a deleted message
to keep sub comments

Related to
#3583 (review)
@jeronimoalbi jeronimoalbi merged commit dc5a753 into gnolang:devx/feature/boardsv2 Jan 27, 2025
10 checks passed
@jeronimoalbi jeronimoalbi deleted the feat/resolve-todos branch January 27, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants