-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards2): improve public realm functions #3583
feat(boards2): improve public realm functions #3583
Conversation
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@@ -188,7 +188,7 @@ func (post *Post) DeleteReply(replyID PostID) error { | |||
return errors.New("reply not found in thread") | |||
} | |||
|
|||
// TODO: Remove child replies too! | |||
// TODO: Shouldn't reply be hidden instead of deleted? Maybe replace reply by a deleted message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be solved in a following PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #3606
@x1unix this PR is ready for review 🙏 |
…lies (#3606) Replies are soft deleted by replacing their body with a deleted message to keep sub comments Related to #3583 (review)
The PR simplifies the implementation of a couple public boards2 realm functions and change them to be up to date with the latest permission handling changes.
These changes also allow a creator of a thread to edit it without permission, or creators of a reply/comment to delete the reply.
Also creators of a thread are allowed to delete it for now. This behavior might change in future PRs.