Test5 Setup #1
Test5 Setup #1
Conversation
Thanks, I didn't pay attention to that. Actually I had them explicitly in any file because I lately passed to a fully |
There was a problem hiding this comment.
👏 👏 👏
Perhaps non-standard, I'm pinging @n2p5 for his thoughts on the overall structure 🙏
| # - role: worker |
There was a problem hiding this comment.
adding comment explaining what is this for
| "address": "g1gpk4kevmhgcah55k00suf44z4u6h09aspasnsn", | ||
| "pub_key": { | ||
| "@type": "/tm.PubKeyEd25519", | ||
| "value": "ShW4HF5UhY7jB42xebdKRdjnqRKoxhZIvSvybe4aaQM=" |
There was a problem hiding this comment.
Where is the corresponding key for this?
There was a problem hiding this comment.
Correct.
The genesis refers to a ref validator (under ../validator folder) whose secrets were removed to avoid secrets leaking.
However since the validator has just dev purposes his secrets can be committed.
| # mountPath: /gnoroot/gnoland-genesis | ||
| - -data-dir=/gnoroot/gnoland-data/ # left as reference | ||
| - -genesis=/gnoroot/gnoland-data/genesis.json # loaded from init container | ||
| - -log-level=info |
There was a problem hiding this comment.
Heavily recommend we use debug. What do you think?
There was a problem hiding this comment.
this is a leftover to reduce load on local instance
| // Executes main logic | ||
| func execApiCallCms(_ context.Context, cfg *cmd.ApiCallerCfg) error { | ||
| if cfg.AuthToken == "" { | ||
| fmt.Println("Error: Missing required argument: BetterStack Auth Token.") |
There was a problem hiding this comment.
What do you think about using the gnolang/gno logger / commands IO?
There was a problem hiding this comment.
Please ignore all this bettestack related code...
It has already be fixed but I want it to be handled and reviewed in a total separated PR
| *gnoService.ApplyPrefix(cfg.MonitorPrefixName)) | ||
|
|
||
| if err != nil { // silently catch error | ||
| fmt.Println("%w", err) |
| switch concretePayload := payload.(type) { | ||
| case GnoMonitorPayload, CreateMonitorGroupPayload, CreateMonitorPayload: | ||
| jsonBody, err = json.Marshal(concretePayload) | ||
| default: | ||
| jsonBody, err = json.Marshal(payload) | ||
| } |
There was a problem hiding this comment.
Why do you need the switch?
| endpoint := fmt.Sprintf("%s%s", bsapi.BaseUrl, api.Endpoint) | ||
| var jsonBody []byte | ||
| switch api.Method { | ||
| case "POST": |
There was a problem hiding this comment.
We can use the http package constants
| @@ -0,0 +1,24 @@ | |||
| package betterstatus | |||
There was a problem hiding this comment.
We can improve the go packages in this PR, but this isn't the point of the PR :)
I'm fine with merging them as-is, even if they can use a cleanup
Full setup of Test5 based on:
Using the following tools: