Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove the time field from the tx signature payload #144

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: Remove the time field from the tx signature payload #144

merged 1 commit into from
Apr 29, 2024

Conversation

jinoosss
Copy link
Member

Description

This PR is a change from gnolang/gno#1939.

No longer handle the time field when signing off-chain.

Remove the time field from the tx signature payload.

zivkovicmilos
zivkovicmilos approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it :)

@zivkovicmilos zivkovicmilos marked this pull request as ready for review April 23, 2024 09:50
@zivkovicmilos
Copy link
Member

Waiting to merge this upon merging gnolang/gno#1939.
Will do a release immediately 🙏

@adr-sk adr-sk mentioned this pull request Apr 24, 2024
Open
@zivkovicmilos zivkovicmilos merged commit 708a96d into gnolang:main Apr 29, 2024
2 checks passed
@jinoosss jinoosss deleted the fix/remove-time-from-tx-sign-payload branch April 29, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

Assignees

@jinoosss jinoosss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinoosss @zivkovicmilos