Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ordering on new filtered methods. #106

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

ajnavarro
Copy link
Collaborator

Add a new field apart from where to make it possible to change the output ordering for new filtered methods.

@ajnavarro ajnavarro requested a review from a team as a code owner October 22, 2024 16:14
storage/pebble.go Outdated Show resolved Hide resolved
@Kouteki Kouteki added the in focus Core team is actively working on this label Nov 7, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

.github/golangci.yaml Outdated Show resolved Hide resolved
internal/mock/storage.go Show resolved Hide resolved
internal/mock/storage.go Show resolved Hide resolved
serve/graph/all.resolvers.go Show resolved Hide resolved
storage/pebble.go Outdated Show resolved Hide resolved
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
@ajnavarro ajnavarro force-pushed the feature/add-ordering-for-new-methods branch from 4901468 to 20e667e Compare November 28, 2024 10:26
@ajnavarro ajnavarro merged commit dbea8f5 into main Nov 28, 2024
4 checks passed
@ajnavarro ajnavarro deleted the feature/add-ordering-for-new-methods branch November 28, 2024 11:48
@Kouteki Kouteki removed the in focus Core team is actively working on this label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants