Skip to content

Commit

Permalink
[dhcpv6] Re-enable test broken by float arithmetic
Browse files Browse the repository at this point in the history
Re-enable tests that were disabled due to floating-point arithmetic
changes in the rust standard library. The behavior of floating-point
arithmetic went back to rounding vs truncating in
rust-lang/rust#96051, so it's safe to enable
these tests again.

A new bug has been filed to track the work to avoid doing
floating-point arithmetic. The complication is that `StepRng` is
behaving in unexpected ways and preventing migration of the existing
unit tests.

Fixed: 92923
Bug: 102199

Change-Id: I3372193a8d59f1bc0d816e9921056bb85fb290d4
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/643581
Reviewed-by: Jake Fried <[email protected]>
Reviewed-by: Ghanan Gowripalan <[email protected]>
Commit-Queue: Tony Gong <[email protected]>
  • Loading branch information
marinaciocea-zz authored and CQ Bot committed Jun 14, 2022
1 parent efd151c commit 0d4a20e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/connectivity/network/dhcpv6/core/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5290,7 +5290,6 @@ mod tests {
// NOTE: All comparisons are done on millisecond, so this test is not affected by precision
// loss from floating point arithmetic.
#[test]
#[ignore]
fn retransmission_timeout() {
let mut rng = StepRng::new(std::u64::MAX / 2, 0);

Expand Down

0 comments on commit 0d4a20e

Please sign in to comment.