This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Claim hooks pt 1 - useClaimCallback #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
commented
Dec 24, 2021
| setAttempting(true) | ||
| claimCallback() | ||
| claimCallback([{ index: 1080 }]) |
There was a problem hiding this comment.
Trying to claim the claim 1080 for account 0x0Ae21f9700eD15E1a83baa3183a67d54b1DA2086
There was a problem hiding this comment.
use registerOnWindow and make a global index changeable?
There was a problem hiding this comment.
Don't think it's worth the effort, we'll soon wire this up with the UI
alfetopito
commented
Dec 24, 2021
alfetopito
commented
Dec 24, 2021
|
added 5 commits
December 24, 2021 08:09
alfetopito
force-pushed
the
claim-hooks-1
branch
from
ba44ffd to
a4c1b3b
Compare
alfetopito
commented
Dec 24, 2021
Comment on lines
-54
to
+56
| const { account, chainId } = useActiveWeb3React() | ||
| const { chainId } = useActiveWeb3React() | ||
|
|
||
| const account = '0x0Ae21f9700eD15E1a83baa3183a67d54b1DA2086' |
There was a problem hiding this comment.
Temporary hard coded changes
alfetopito
commented
Dec 24, 2021
| @@ -57,7 +57,7 @@ export const V_COW_CONTRACT_ADDRESS: Partial<Record<number, string>> = { | |||
| // [ChainId.MAINNET]: GPv2Settlement[ChainId.MAINNET].address, | |||
| // [ChainId.RINKEBY]: GPv2Settlement[ChainId.RINKEBY].address, | |||
| // [ChainId.XDAI]: GPv2Settlement[ChainId.XDAI].address, | |||
| [ChainId.RINKEBY]: '0x8f07778b703f9feb93521fc5230e859dbd032b6b', | |||
| [ChainId.RINKEBY]: '0xac17Ae2BcAF9Ed181C4Ab10B179548d6aa30C92E', | |||
There was a problem hiding this comment.
This is why it didn't work before, I was using the wrong contract address...
There was a problem hiding this comment.
alfetopito
changed the title
W3stside
reviewed
Dec 24, 2021
W3stside
reviewed
Dec 24, 2021
W3stside
reviewed
Dec 24, 2021
W3stside
reviewed
Dec 24, 2021
W3stside
reviewed
Dec 24, 2021
W3stside
reviewed
Dec 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated
ClaimTypefrom a TS type to an enum, to be inline with contractAdded modified
useClaimCallbackExample of a successful tx claiming
1080https://rinkeby.etherscan.io/tx/0x90ad7c1ffc412c75286f91ae821c23397bbe0e2e75fdcf6e5961101c7b1f220eTo Test
1080(no way to do that in the UI yet)claim vCOWclaimin the modalYour transaction should be sent
Background
Optional: Give background information for changes you've made, that might be difficult to explain via comments