This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W3stside
commented
Jan 4, 2022
ab361fc
to
966d6bc
Compare
|
966d6bc
to
b5d9b33
Compare
maria-vslvn
pushed a commit
that referenced
this pull request
Jan 6, 2022
alfetopito
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
5976bde
to
972e07c
Compare
nenadV91
reviewed
Jan 10, 2022
}, [transactions]) | ||
} | ||
|
||
export function useAllClaimingTransactionIndices() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming every claim has data, we could write this like
export function useAllClaimingTransactionIndices() {
const claimingTransactions = useAllClaimingTransactions()
return useMemo(() => new Set(claimingTransactions.flatMap(({ data }) => data)), [claimingTransactions])
}
nenadV91
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMI, only thing is as we discussed we should also include pending claims into unclaimed amount calculation at some point.
Merged
- add hooks as syntactic sugar
972e07c
to
e9debfe
Compare
Claim pending update
[Claim] - Mod useUserHasSubmittedClaim
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 1: pending UI for claiming. Users whom submit a claim and while pending should receive feedback in the claiming window of any ongoing claims. Only really applicable should a user hit "back" while claiming and/or refresh
Screenshots
Pending view for users whom make it back to the

/claim
page while claim on-going:Where to get addresses to use to show claim flow and where to find claim indices to use in mock fn:

Example of how to trigger mock transactions in console:

To Test
0x00059034c8759f5C89af6792Eb3cFa2CCd12f6f3
(found here: https://github.com/gnosis/cow-merkle-drop/blob/main/rinkeby/chunks/0x00059034c8759f5C89af6792Eb3cFa2CCd12f6f3.json)2a. ☝️ can also be any account with claims, just paste the account into cowswap AND also remember one or several of the claiming index(ices) for later
addMockClaimTransactions([<INDEX/INDICES_FROM_STEP_2a>])
to add claiming txs to activity log5a. e.g:
addMockClaimTransactions([0, 1, 2, 3, 4, 5]) // assuming the chunks addressed is pulled from has those indices
TODO