This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Real airdrop repo #2052
Merged
Real airdrop repo #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@alfetopito and @nenadV91 there is some clashing stuff here between your 2 branches. imo this should be merged into main and then @nenadV91 you rebase your work again |
W3stside
reviewed
Jan 5, 2022
| @@ -145,7 +146,7 @@ export function useUserClaims(account: Account): UserClaims | null { | |||
| return | |||
| } | |||
|
|
|||
| fetchClaims(account) | |||
| fetchClaims(account, chainId) | |||
There was a problem hiding this comment.
nit: you know how i feel about these types of function args, would prefer an object as the others are made but i can live with this
W3stside
reviewed
Jan 5, 2022
| @@ -365,3 +366,83 @@ function _hasNoInputOrInputIsGreaterThanClaimAmount( | |||
| ): input is Required<ClaimInput> { | |||
| return !input.amount || JSBI.greaterThan(JSBI.BigInt(input.amount), JSBI.BigInt(claim.amount)) | |||
| } | |||
|
|
|||
| type LastAddress = string | |||
| type ClaimAddressMapping = { [firstAddress: string]: LastAddress } | |||
There was a problem hiding this comment.
Suggested change
| type ClaimAddressMapping = { [firstAddress: string]: LastAddress } | |
| type ClaimAddressMapping = Record<string, LastAddress> |
There was a problem hiding this comment.
I agree, but it's all copied code. Wanted to not change what's not needed.
If you feel strongly I can completely refactor it.
W3stside
reviewed
Jan 5, 2022
W3stside
reviewed
Jan 5, 2022
W3stside
reviewed
Jan 5, 2022
W3stside
reviewed
Jan 5, 2022
W3stside
reviewed
Jan 5, 2022
Co-authored-by: David <[email protected]>
|
As discussed, merging to get the latest data onto |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fetching claim data from claim repo https://github.com/gnosis/cow-merkle-drop
To Test
vCOWon top)Note:
Claiming not yet wired up, it won't work
Commented out Michel's code on claim page, definitely not final
Background
Optional: Give background information for changes you've made, that might be difficult to explain via comments