Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim hooks 3 #2056

Merged
merged 16 commits into from
Jan 6, 2022
Merged

Claim hooks 3 #2056

merged 16 commits into from
Jan 6, 2022

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Jan 6, 2022 •
edited
Loading

Summary

Several things in this PR

  1. New contract methods
  2. New hooks using those methods
  3. Checking whether investment is open for investment/airdrop and showing it on the claim page

Screen Shot 2022-01-05 at 18 15 27

  1. Added prices
  2. Calculating ETH when investment type is UserOption -- can't test it as investment window is closed on the contract

To Test

  1. On claim page, check for an address that has airdrop only
  • Should see no warning
  1. Then check for account that has at least 1 investment option

  • Should see warning as investment window is closed

    Background

Optional: Give background information for changes you've made, that might be difficult to explain via comments

@alfetopito alfetopito self-assigned this Jan 6, 2022
@alfetopito alfetopito requested a review from a team January 6, 2022 02:26
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

W3stside
W3stside approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with comments:

Leandro added 15 commits January 6, 2022 13:39
Added new methods to vCow contract's json interface and re-generated …
3eac13d 
…the types
Fixing bad merge reverting values back
5857c8b
Hard coding prices fetched from the contract for now
1a32402
Added hook useDeploymentTimestamp to fetch contract deployment timestamp
51d9a3c
Added helper hooks to check whether claim window is still open for ea…
9c94900 
…ch type
Properly calculating ETH value from vCowAmount
5cda7b9
Short update to prices constants comment regarding the unit
c52a8ce
Typo fix
d9aa358
Turned hasClaims into a boolean rather than number
81affdc
Adding two dumb checks regarding investment window for testing
5244058
Using ms.macro lib for calculating weeks in ms
4887191
Using ethers parseUnits function
b211a5c
Refactored hooks to return always a boolean, never null
1058aec
Made notive token price calculation chain based
119ebd4
Validating claims are still claimable on claim callback
c813cbb
@alfetopito
Copy link
Contributor Author

Merging, will address further comments in follow up PRs

@alfetopito alfetopito merged commit efcb9ad into claim Jan 6, 2022
@alfetopito alfetopito deleted the claim-hooks-3 branch January 6, 2022 23:20
@alfetopito alfetopito mentioned this pull request Jan 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfetopito @W3stside