This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[Claim refactor index] - Part 1 - Extrapolate 5 small components (summary, nav, claim messages) #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alfetopito
approved these changes
Jan 10, 2022
W3stside
force-pushed
the
claim-refactor-index
branch
from
ebc4872 to
91e7773
Compare
|
|
Tried it out now, flow looks the same 👍 |
W3stside
force-pushed
the
claim-refactor-index
branch
from
91e7773 to
8ed0258
Compare
anxolin
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Nice you broke it down, thanks for refactoring, however not so fan of the current approach.
Anyways, we will move forwards and try to make this look more similar to other components of the app (use redux state) and simplify the state (i.e. don't add so many booleans for mutually exclusive state
| import { IntroDescription } from './styled' | ||
| import { ClaimCommonTypes } from './types' | ||
|
|
||
| type ClaimIntroductionProps = Pick<ClaimCommonTypes, 'hasClaims'> & { |
There was a problem hiding this comment.
is all this better than adding just a hasClaims: boolean
if we use the approach i sugges:
CONS:
- yes if
hasClaimschange type, it will be automatic
PRO
- Way easier to read
- More self contain component. You don't need to artificially get some other type to get a field from it
anxolin
force-pushed
the
claim-refactor-index
branch
from
8ed0258 to
c99d373
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extrapolates some
claim > index.tscode into 5 small components (summary, nav, claim messages)Uses the claim context to make this easier
Can be tested by just using the claim flow. same info should show as
claimbuild