Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update xdai and wxdai token logo #2122

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Update xdai and wxdai token logo #2122

merged 4 commits into from
Jan 13, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Jan 12, 2022

Summary

Fixes #1179
Before:
image
After:
image

To Test

  1. Open the page swap
  2. Connect a wallet while on xDai network
  3. Pick xDai and wxDai
  4. Check the token logos. Should look like the screenshot above.

@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team labels Jan 12, 2022
@alongoni alongoni self-assigned this Jan 12, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@@ -24,7 +24,6 @@ export const ADDRESS_IMAGE_OVERRIDE = {
[USDC_XDAI.address]: getTrustImage(USDC.address),
// [USDT_XDAI.address]: getTrustImage(USDT.address),
[WBTC_XDAI.address]: getTrustImage(WBTC.address),
[WXDAI.address]:
'https://raw.githubusercontent.com/1Hive/default-token-list/master/src/assets/xdai/0xe91d153e0b41518a2ce8dd3d7944fa863463a97d/logo.png',
[WXDAI.address]: 'assets/images/wxdai.png',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import wxDaiLogo from 'assets/images/wxdai.png'

...
[WXDAI.address]: wxDaiLogo,
...

@alongoni alongoni added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Jan 12, 2022
@alongoni alongoni marked this pull request as ready for review January 12, 2022 19:02
anxolin pushed a commit that referenced this pull request Jan 12, 2022
* fix: center import pool text V2

* fix: updated based on feedback

Co-authored-by: Matthew Quinn <[email protected]>
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look soooo good! I love it!

@elena-zh
Copy link

Looks great!
One tiny question: xDAI icon still looks like a broken one in the activity modal. Is this OK for this PR?
image

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have forgotten that the issue with ETH/XDAI tokens in the activity modal is a known one #2006 and is not related to the current PR.
The current changes are approved!

Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, as well as xDai's brand update.

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 13, 2022
@mergify mergify bot merged commit ddf8ca6 into develop Jan 13, 2022
@alongoni alongoni deleted the 1179-xdai-logo branch January 13, 2022 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The icon of DAI on xDAI chain is the same the icon of ETH
5 participants