This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Fix native investment #2123
Merged
Fix native investment #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
pushed a commit
that referenced
this pull request
Jan 12, 2022
…2123) * logic for tracking time since last block * add polling times to chain info * pr feedback * add gui for chain connectivity warning * add arb support * update title of warning to indicate internet connectivity issues may be the problem * pr review * clean up useBlockWarningTimer * softer language on mainnet * only show warning if user has the window visible
alfetopito
force-pushed
the
fix-claim-native-investment
branch
2 times, most recently
from
3889626 to
02b216c
Compare
|
W3stside
reviewed
Jan 14, 2022
W3stside
approved these changes
Jan 15, 2022
added 5 commits
January 17, 2022 11:28
…rOption claim" This reverts commit ca8fd2f.
alfetopito
force-pushed
the
fix-claim-native-investment
branch
from
02b216c to
5f9a3d1
Compare
alfetopito
added
the
Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing bug with Native investment
Example of a successful claim using ETH https://rinkeby.etherscan.io/tx/0x63b9138efd234380362babc8bb2e6566750a2e9ea83ce10fe9b4862c6ad31f0f
The issue was that
parseUnitsadds X zeroes to the value passed in, but what I wanted is to remove them.Switched back to JSBI.divide by 10**18 and now it gives us the proper amount :)
Test
Notes this change might break the investor flow. I can revert that, it's on only to make sure the claiming is working
Accounts
I filtered this list based on accounts that ONLY have ETH claims to make sure you don't need anything else (GNO/USDC)